Skip to content

Update compiler target version in gulp and extension tsconfig#1776

Merged
norascheuch merged 1 commit intomainfrom
nora/update-compiler-target
Nov 22, 2022
Merged

Update compiler target version in gulp and extension tsconfig#1776
norascheuch merged 1 commit intomainfrom
nora/update-compiler-target

Conversation

@norascheuch
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch commented Nov 21, 2022 •
edited
Loading

Update compiler target version in gulp and extension tsconfig to adjust it to our node version.

Tested locally (a couple of normal Query runs with Run Query and Run Query on Multiple Databases)

All in all we have 7 relevant tsconfig files, 2 are adjusted here, 3 others already use es6, 2 extend a config that uses es6.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@norascheuch norascheuch marked this pull request as ready for review November 22, 2022 09:16
@norascheuch norascheuch requested a review from a team as a code owner November 22, 2022 09:16
@norascheuch norascheuch merged commit 33eb334 into main Nov 22, 2022
@norascheuch norascheuch deleted the nora/update-compiler-target branch November 22, 2022 10:55
@elenatanasoiu
Copy link
Copy Markdown
Contributor

elenatanasoiu commented Nov 22, 2022

Just mentioning that we checked that VSCode uses es2021 as well: https://github.com/microsoft/vscode/blob/main/src/tsconfig.json#L8

@alexet
Copy link
Copy Markdown

alexet commented Nov 25, 2022

The vscode version we claim we support doesn't target es2021. So I am not sure this is correct at least not with a minimum version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@elenatanasoiu elenatanasoiu elenatanasoiu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@norascheuch @elenatanasoiu @alexet